[34/n] sled-agent logic to clear mupdate overrides #8572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Jul 12, 2025
Comment on lines
430
to
433
| // Reconcile the mupdate override field. This can be done independently | ||
| // of the other parts of reconciliation (and this doesn't have to block | ||
| // other parts of reconciliation), but the argument for this is somewhat | ||
| // non-trivial. Here's an outline: |
There was a problem hiding this comment.
Worth having a look at this.
There was a problem hiding this comment.
I've moved this to https://rfd.shared.oxide.computer/rfd/0556#sa_reconciler_error_handling.
sunshowers
changed the title
sunshowers
added a commit
that referenced
this pull request
Jul 16, 2025
#8596) While working on #8572, we realized that we need to put in a condition saying that if any zones can't be switched over to Artifact, we must not clear the mupdate override field. This effectively requires information about eligibility to be available in two spots: while updating the mupdate override, and while doing these noop conversions. In order to do that more easily, this PR builds up a decision tree by sled.
Created using spr 1.3.6-beta.1
sunshowers
changed the title
sunshowers
changed the title
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements logic within sled-agent to clear mupdate overrides. Includes tests, database storage, and displayers.
This logic by itself does not introduce behavior changes, since the code to actually set this field is in #8456.
Depends on: